This repository has been archived by the owner on Jan 21, 2021. It is now read-only.
Add serializer for DataType retrieval #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def getDataTypes(List conceptKeysList){ | ||
| List cohortDataTypes = [] | ||
| Map datatypesMap = [:] | ||
| public def getDataTypes(List conceptKeysList, List dataTypes, Integer cohortNumber){ |
There was a problem hiding this comment.
some small remarks:
- use cmd+alt+L (in your IntelliJ on Mac at least) to format your code nicely. This way you will avoid style guide mistakes (we follow the google one for java - see the wiki) like lack of space between closing and opening brancets: ){
- cohortNumber can probably be just int
| conceptKeysList.each { conceptKey -> | ||
| OntologyTerm concept = conceptsResourceService.getByKey(conceptKey) | ||
| datatypesMap = getHighDimDataType(concept, datatypesMap) | ||
| dataTypes = getDataType(concept, dataTypes) |
There was a problem hiding this comment.
was your intension here to create a collection of dataTypes and return this collection ?
If yes - then you could use .collect() {element-> getDatatype(...)}
this forEach loop looks as if it was overwriting dataTypes over and over.
PiotrZakrzewski
approved these changes
Nov 10, 2016
| throw new NoSuchResourceException("No parameter named concepts was given.") | ||
| } | ||
|
|
||
| if (params.get('concepts') == "") { |
There was a problem hiding this comment.
can be replaced with
if (params.get('concepts'))
| } | ||
|
|
||
| def getHighDimDataType(OntologyTerm term, Map datatypesMap) { | ||
| private void getDataType(String conceptKey, List dataTypes, int cohortNumber) { | ||
| OntologyTerm term = conceptsResourceService.getByKey(conceptKey) | ||
| // Retrieve all descendant terms that have the HIGH_DIMENSIONAL attribute |
There was a problem hiding this comment.
this comment is intended as a description of this method right?
Then you should put it on top of the method declaration like this:
/**
* description of the functionality
*/
method() {}
Jarvanerp
force-pushed
the
gb-dev-data-export
branch
from
5a52096
to
2da53ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with:
thehyve/transmart-rest-api#36