Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chrome download from chrome-for-testing #104

Closed
wants to merge 1 commit into from
Closed

Update Chrome download from chrome-for-testing #104

wants to merge 1 commit into from

Conversation

rhpijnacker-philips
Copy link

Fixes #103.

@gitgrimbo gitgrimbo mentioned this pull request Oct 15, 2023
Merged
@jason0x43
Copy link
Member

This looks reasonable, although there are some test failures.

Some of those can be fixed by setting tunnel.webdriverDataUrl = null right after every tunnel creation in tests/integration/SeleniumTunnel.ts. This ensures that the tests are using the webdrivers.json file in the current branch instead of the one on the website (which is probably how the tests should have always worked).

Fixing that reveals some other issues. In particular, the constructed URLs for Linux and Mac no longer appear to be valid.

@jason0x43
Copy link
Member

This was closed in favor of #105.

@jason0x43 jason0x43 closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downloading recent ChromeDrivers fails
2 participants
@rhpijnacker-philips @jason0x43