Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M.A might not be available, you should use M.toarray() #410

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Zhongzheng99
Copy link
Contributor

In some versions of scipy(e.g. 1.14), M.A might not be available. In such cases, you should use M.toarray() to convert the sparse matrix to a dense one.

In some versions of scipy(e.g. 1.14), M.A might not be available. In such cases, you should use M.toarray() to convert the sparse matrix to a dense one.
@Zhongzheng99
Copy link
Contributor Author

Zhongzheng99 commented Jul 24, 2024

Closes #412

mumichae
mumichae approved these changes Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (9c5a936) to head (7730418).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files          22       22           
  Lines        1683     1683           
=======================================
  Hits          919      919           
  Misses        764      764           
Flag Coverage Δ
unittests 54.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scib/metrics/utils.py 51.04% <100.00%> (ø)

@mumichae mumichae merged commit 9271d92 into theislab:main Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants