Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UTF-8 right single-quote (’) with ASCII single-quote (') #15

Open
wants to merge 1 commit into
base: 2022-pshare
Choose a base branch
from

Conversation

HeroCC
Copy link

@HeroCC HeroCC commented Mar 10, 2023

Currently, the UTF-8 right single quote mark is used in a few files. This can cause issues on some systems which aren't configured to use UTF-8 as their default charset. For example, when cloning, SVN halts when pulling the multicast_7’ file unless $LC_CTYPE is a UTF8-like:

$ echo $LC_CTYPE

$ svn up
...
A    MOOS_Jan2123/MOOSEssentials/Essentials/pShare/pshare_test_scripts
svn: E000022: Can't convert string from 'UTF-8' to native encoding:
svn: E000022: /home/moos/moos-ivp/MOOS_Jan2123/MOOSEssentials/Essentials/pShare/pshare_test_scripts/multicast_7'
# fatal error

# Swap to UTF-8 encoding
$ export LC_CTYPE=C.UTF-8
$ svn up
# successfully completes

This PR removes the log file which causes this to happen with SVN, and replaces the token in a few code examples, hopefully preventing it from happening again. The symbol is used all over the readme.md file, but I only updated the occurrences inside codeblocks.

HeroCC added a commit to HeroCC/MOOSDocker that referenced this pull request Mar 10, 2023
Currently, the locale is the POSIX default "C".
Some files in the moos tree, however, use UTF-8 characters, which can
cause applications to fail (notably, the SVN checkout & update process).
See themoos/essential-moos#15 for more context.

This commit changes the default to "C.UTF-8", enabling use of the
extended charset.
HeroCC added a commit to HeroCC/moos-ivp that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant