Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include StandardJS Javascript Style Guide #175

Open
quadrophobiac opened this issue Jul 6, 2017 · 2 comments · May be fixed by #177
Open

Include StandardJS Javascript Style Guide #175

quadrophobiac opened this issue Jul 6, 2017 · 2 comments · May be fixed by #177
Labels
fn:Documentation fn:Usability i:enhancement

Comments

@quadrophobiac
Copy link
Collaborator

A bare bones Javascript style guide has been cribbed from Electron. Has anyone any recommendations on a good JS style guide for use in our contributors guide?
@quadrophobiac
Copy link
Collaborator Author

excellent discussion on this topic in this PR #174

@quadrophobiac
Copy link
Collaborator Author

quadrophobiac commented Jul 12, 2017 •
edited
Loading

Using @chris48s's response to spec this ticket

  • Add standard js to project requirements

  • Bring existing code into line with guidance:

    • Run standard --fix on codebase to automatically convert as much as possible to to standard js conventions
    • Mop any issues that need manual intervention

  • Remove JsHint config files (.jshintrc, .jshintignore) from root/subdirs + JsHint package

  • Edit Travis config to run Standard Js linter in CI build instead of JsHint

  • add Standard Badge to repo JavaScript Style Guide

@quadrophobiac quadrophobiac changed the title Javascript Style Guide? Include StandardJS Javascript Style Guide Jul 12, 2017
@quadrophobiac quadrophobiac linked a pull request Jul 14, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fn:Documentation fn:Usability i:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standard js style guide (WiP) theodi/comma-chameleon
1 participant
@quadrophobiac