use lib-ec2 security group function and remove own sg function

theonestack · Aug 10, 2020 · 4d162e9 · 4d162e9
1 parent ad4259a
commit 4d162e9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 33 deletions.
diff --git a/application-loadbalancer.cfhighlander.rb b/application-loadbalancer.cfhighlander.rb
@@ -1,6 +1,7 @@
 CfhighlanderTemplate do
 
   # Name 'application-loadbalancer'
+  DependsOn 'lib-ec2'
 
   Parameters do
     ComponentParam 'EnvironmentName', 'dev', isGlobal: true

diff --git a/ext/cfndsl/sg.rb b/ext/cfndsl/sg.rb
diff --git a/tests/security_groups.test.yaml b/tests/security_groups.test.yaml
@@ -5,7 +5,8 @@ test_metadata:
 
 ip_blocks:
   local:
-    - 127.0.0.1/32
+    - ip: 127.0.0.1/32
+      desc: localhost access
     - 127.0.0.2/32
   public:
     - 0.0.0.0/0
@@ -19,6 +20,7 @@ security_group_rules:
     from: 443
     ip_blocks:
       - public
+      - local
     desc: public HTTPS access
   -
     from: 8080