Bump python to 3.8 due to 3.7 EOL (#5)

theonestack · Oct 26, 2023 · a5ac4da · a5ac4da
1 parent e614336
commit a5ac4da
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 23 deletions.
diff --git a/.github/workflows/rspec.yaml b/.github/workflows/rspec.yaml
@@ -3,23 +3,6 @@ name: cftest
 on: [push, pull_request]
 
 jobs:
-  test:
-    name: test
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v2
-    - name: set up ruby 2.7
-      uses: actions/setup-ruby@v1
-      with:
-        ruby-version: 2.7.x
-    - name: install gems
-      run: gem install cfhighlander rspec 
-    - name: set cfndsl spec
-      run: cfndsl -u
-    - name: cftest
-      run: rspec
-      env:
-        AWS_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY }}
-        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-        AWS_REGION: ap-southeast-2
+  rspec:
+    uses: theonestack/shared-workflows/.github/workflows/rspec.yaml@main
+    secrets: inherit
diff --git a/route53-zone.config.yaml b/route53-zone.config.yaml
@@ -22,7 +22,7 @@ route53_custom_resources:
     Route53ZoneCR:
       code: route53_zone_cr.py
       handler: route53_zone_cr.handler
-      runtime: python3.7
+      runtime: python3.8
       timeout: 600
       role: Route53ZoneResource
       environment:

diff --git a/spec/default_spec.rb b/spec/default_spec.rb
@@ -150,7 +150,7 @@
       end
 
       it "to have property Runtime" do
-          expect(resource["Properties"]["Runtime"]).to eq("python3.7")
+          expect(resource["Properties"]["Runtime"]).to eq("python3.8")
       end
 
       it "to have property Timeout" do

diff --git a/spec/override_dns_domain_spec.rb b/spec/override_dns_domain_spec.rb
@@ -150,7 +150,7 @@
       end
 
       it "to have property Runtime" do
-          expect(resource["Properties"]["Runtime"]).to eq("python3.7")
+          expect(resource["Properties"]["Runtime"]).to eq("python3.8")
       end
 
       it "to have property Timeout" do