Merge pull request #2 from Samseppiol/master

Convert component to use new cfndsl yaml constant syntax
theonestack · Jan 13, 2020 · 163da07 · 163da07
2 parents 577f85a + 3668e4e
commit 163da07
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/s3-cloudfront.cfndsl.rb b/s3-cloudfront.cfndsl.rb
@@ -13,8 +13,8 @@
     ]
   }
 
-if defined? bucket_policy
 
+  bucket_policy = external_parameters.fetch(bucket_policy, {})
   bucket_policy.each do |sid, statement_config|
     statement = {}
     statement["Sid"] = sid
@@ -26,11 +26,9 @@
     policy_document[:Statement] << statement
   end
 
-end
-
 
   S3_Bucket('Bucket') do
-    BucketName FnSub(bucket_name)
+    BucketName FnSub(external_parameters[:bucket_name])
   end
 
   S3_BucketPolicy("BucketPolicy") do