fixes #720 admin login & property based auth: invalid credential mess…

…age does not appear Signed-off-by: Julien Buret <jburet@voyages-sncf.com>
theopenconversationkit · Jan 2, 2020 · c09475c · c09475c
1 parent 2d40f0f
commit c09475c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/nlp/admin/web/src/app/core-nlp/auth/login/login.component.css b/nlp/admin/web/src/app/core-nlp/auth/login/login.component.css
@@ -27,7 +27,7 @@
   font-size: smaller;
   cursor: pointer;
 }
-.error {
+.error-message {
   color: red;
 }
 .success {

diff --git a/nlp/admin/web/src/app/core-nlp/auth/login/login.component.html b/nlp/admin/web/src/app/core-nlp/auth/login/login.component.html
@@ -63,10 +63,13 @@
                        id="input-password"
                        placeholder="Password"
                        [required]="true">
-                <ng-container *ngIf="userPassword.invalid && userPassword.touched ">
+                <ng-container *ngIf="errorMessage || (userPassword.invalid && userPassword.touched)">
                   <p class="error-message" *ngIf="userPassword.errors?.required">
                     Password is required!
                   </p>
+                  <p class="error-message" *ngIf="errorMessage">
+                    {{errorMessage}}
+                  </p>
                 </ng-container>
               </div>
               <div class="row">

diff --git a/shared/src/main/kotlin/security/auth/PropertyBasedAuthProvider.kt b/shared/src/main/kotlin/security/auth/PropertyBasedAuthProvider.kt
@@ -155,7 +155,7 @@ internal object PropertyBasedAuthProvider : TockAuthProvider {
                     resultHandler.handle(Future.succeededFuture(tockUser))
                 }
             }
-            ?: Future.failedFuture<User>("invalid credentials")
+            ?: resultHandler.handle(Future.failedFuture<User>("invalid credentials"))
     }
-Original file line number
+Diff line change
@@ Expand Up @@
                         resultHandler.handle(Future.succeededFuture(tockUser))
                     }
                 }
-                ?: Future.failedFuture<User>("invalid credentials")
+                ?: resultHandler.handle(Future.failedFuture<User>("invalid credentials"))
         }
@@ Expand Down @@