Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added safari extension template #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

donato-fiore
Copy link

@donato-fiore donato-fiore commented Jun 25, 2022

What does this implement/fix? Explain your changes.

adds a Safari extension template

Does this close any currently open issues?

no

Any relevant logs, error output, etc?
no


Any other comments?

no

Where has this been tested?

Operating System:
iOS 15.1.1
WSL - Ubuntu 20.04

Platform:
iOS/Linux

Target Platform:
iOS/iPadOS

Toolchain Version:
clang version 10.0.0 (git@github.com:apple/llvm-project.git 3093af41dd65ad466dcd5603e9289244edfee4f5)

SDK Version:
iOS 14.4

Copy link
Member

@kirb kirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited to finally have some plugin templates, thanks for doing this 👍

Just had a few suggestions after looking over it again.

ios/safari_extension/SafariWebExtensionHandler.swift Outdated Show resolved Hide resolved
ios/safari_extension/Makefile Show resolved Hide resolved
ios/safari_extension/Resources/manifest.json Outdated Show resolved Hide resolved
ios/safari_extension/SafariWebExtensionHandler.swift Outdated Show resolved Hide resolved
@L1ghtmann
Copy link
Member

This looks like it fulfills Lillie's request (#25)

donato-fiore and others added 5 commits July 5, 2022 10:18
NIC->variable("PARENTPROJECTNAME") = "";

while(NIC->variable("PARENTPROJECTNAME") eq "") {
NIC->variable("PARENTPROJECTNAME") = NIC->prompt("PROJ", "Name of parent project (required)");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth specifying that by parent project name we mean an application name

@L1ghtmann
Copy link
Member

@LillieH1000 would it be possible for you to confirm the functionality of this template? I am not familiar enough with safari extensions to be able to judge myself

@LillieH1000
Copy link

@LillieH1000 would it be possible for you to confirm the functionality of this template? I am not familiar enough with safari extensions to be able to judge myself

There was one change that @kirb was supposed to make back in 2022 to fix a bundle id issue of theos generating the wrong bundle id for it but besides that it was working in 2022. I'm in the theos discord and can let you know of the exact bundle id thing to make it easier if you want?

@L1ghtmann
Copy link
Member

That would be great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants