added single view application and SpriteKit game template #9
Conversation
|
I have updated the code with the changes that you requested |
|
Hi, what happened to this pull request, will it ever be merged? |
|
The overall code formatting looks off. Check the other templates so that lots of unnecessary empty lines can be removed and the indentation can be consistent. |
There was a problem hiding this comment.
I apologise for taking this long to properly review this PR
Please remove unnecessary empty lines from control files, Makefiles and source files. Rename "menuScene" to "MenuScene" and "myScene" to "MainScene".
What's the origin of the App icon images? Are they public domain or similar attribution?
| </array> | ||
| <key>UIRequiredDeviceCapabilities</key> | ||
| <array> | ||
| <string>armv7</string> |
There was a problem hiding this comment.
You might want to add arm64 to the list
| include @@THEOS@@/makefiles/common.mk | ||
|
|
||
| APPLICATION_NAME = @@PROJECTNAME@@ | ||
|
|
| @@ -0,0 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
Import UIKit as we no longer do that implicitly
| @@ -0,0 +1,38 @@ | |||
| #import "ViewController.h" | |||
|
|
|||
| @@ -0,0 +1,5 @@ | |||
| name "iphone/application_spriteKit_game" | |||
|
|
|||
|
|
||
| #import <SpriteKit/SpriteKit.h> | ||
| @interface myScene : SKScene <SKPhysicsContactDelegate> | ||
| -(instancetype)initWithSize:(CGSize)size; |
There was a problem hiding this comment.
Please do not indent method protocol lines
|
|
||
|
|
||
| #import <SpriteKit/SpriteKit.h> | ||
| @interface myScene : SKScene <SKPhysicsContactDelegate> |
There was a problem hiding this comment.
Class does not conform to convention (PascalCase)
| @@ -0,0 +1,3 @@ | |||
| @interface ViewController : UIViewController | |||
There was a problem hiding this comment.
Import UIKit as we no longer do that implicitly
| Description: An awesome Game! | ||
| Maintainer: @@USER@@ | ||
| Author: @@USER@@ | ||
| Section: Utilities |
| Description: An awesome single view application! | ||
| Maintainer: @@USER@@ | ||
| Author: @@USER@@ | ||
| Section: Utilities |
|
Is there still a use case for a SpriteKit game template? If so, we can likely go ahead with editing this in-place as the requested changes don't appear to have been addressed. Also, it seems that the application template pr'd is extremely similar to the one introduced in 12a565a except that is presents a UIView instead of a UITableView. Given this, I'm in favor of removing that portion for the pr. |
Added a template for a single view application which contains a simple UIViewController with a white background
And a SpriteKit template for making games using theos (I've made some games using it ) contains two scnes one for the menu and one for the game
The are both to easy to understand and work with
Hopefully this helps people who want to make apps but doesn't have XCode to do so
I've made a full functionality apps using these templates