Fix SMF adding contracts to a location that has no contracts yet (#379)

thepeacockproject · Feb 2, 2024 · ecf07da · ecf07da
1 parent c4e0980
commit ecf07da
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/components/controller.ts b/components/controller.ts
@@ -521,10 +521,16 @@ export class Controller {
                                 .peacockIntegration === "undefined" ||
                             contractData.SMF.destinations.peacockIntegration
                         ) {
-                            if (contractData.SMF.destinations.placeBefore) {
+                            const missions =
                                 controller.missionsInLocations[
                                     contractData.Metadata.Location
-                                ].splice(
+                                ] ??
+                                (controller.missionsInLocations[
+                                    contractData.Metadata.Location
+                                ] = [])
+
+                            if (contractData.SMF.destinations.placeBefore) {
+                                missions.splice(
                                     controller.missionsInLocations[
                                         contractData.Metadata.Location
                                     ].indexOf(
@@ -537,9 +543,7 @@ export class Controller {
                             } else if (
                                 contractData.SMF.destinations.placeAfter
                             ) {
-                                controller.missionsInLocations[
-                                    contractData.Metadata.Location
-                                ].splice(
+                                missions.splice(
                                     controller.missionsInLocations[
                                         contractData.Metadata.Location
                                     ].indexOf(
@@ -550,9 +554,7 @@ export class Controller {
                                     contractData.Metadata.Id,
                                 )
                             } else {
-                                controller.missionsInLocations[
-                                    contractData.Metadata.Location
-                                ].push(contractData.Metadata.Id)
+                                missions.push(contractData.Metadata.Id)
                             }
                         }
                     }