Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update (parts of) some contracts to match newest IOI version #295

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

grappigegovert
Copy link
Member

I've updated some contracts to the newest available version on IOI servers.

Generally, only contracts where objectives didn't match the newest version have been altered, with some exceptions:

  • the addition of VR bricks in two facility escalations;
  • the addition of ForceShowOnLoadingScreen in The Last Yardbird;

I have also modified the ordering of properties to match what we already had and dismissed some irrelevant property changes to keep the total amount of changes minimal.

Fixes #287, #285, and #284.

@AnthonyFuller
Copy link
Contributor

I notice some 2016 escalations have been changed, do they still work in 2016?

@RDIL RDIL added the escalations Related to the escalation system or a specific escalation. label Jul 2, 2023
@grappigegovert
Copy link
Member Author

grappigegovert commented Jul 2, 2023

I notice some 2016 escalations have been changed, do they still work in 2016?

That's a good question.
The marrakesh->salvia levels 3-5 have some changed logic in the body hide objective. They now match what's on H3 servers.
I cannot test 2016 right now, but it's a good idea to do so before merging.

Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the ones from 2016, they all look good.

@AnthonyFuller AnthonyFuller merged commit a0a2773 into v7 Aug 5, 2023
7 checks passed
@AnthonyFuller AnthonyFuller deleted the contracts-refresh branch August 5, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
escalations Related to the escalation system or a specific escalation.
Projects
None yet
4 participants