Add handling of arrays of objects #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
RDIL
requested changes
Jul 24, 2024
src/arrayHandling.ts
Outdated
| // handle properties of an object | ||
| if (typeof item === "object") { | ||
| const newReference = `$${reference.substring( | ||
| reference.indexOf("#.") + 1, |
There was a problem hiding this comment.
thinking this could break in the scenario of nested $inarray/$any/$all (unless im actually a coding genius and thought of that when building this function, which I might have, but still worth double checking)
There was a problem hiding this comment.
I thought it might, but since it's actually checking if it's before before it returns something, it shouldn't. The code before it does something similar to this. There probably needs to be a test for this.
RDIL
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.