Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitattributes #56

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Update .gitattributes #56

merged 1 commit into from
Dec 22, 2023

Conversation

reedy
Copy link
Contributor

@reedy reedy commented Dec 21, 2023

No description provided.

@reedy
Copy link
Contributor Author

reedy commented Dec 21, 2023

Similar to #53

@nyamsprod nyamsprod merged commit deec415 into thephpleague:2.4.x Dec 22, 2023
6 checks passed
@nyamsprod
Copy link
Member

@reedy I have merge your PR but I am not sure I will release it for the 2.x version. The reason being that this version is now on security fix only. And your PR does not address any security fix.

@nyamsprod nyamsprod self-assigned this Dec 22, 2023
@reedy
Copy link
Contributor Author

reedy commented Dec 22, 2023

Yeah that's understandable. If a release happens it can be included. If not, it's not the end of the world!

Thanks :)

@reedy reedy deleted the patch-2 branch December 22, 2023 10:07
@nyamsprod
Copy link
Member

true hence why I still did merge it... we never know 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants