buf pool for MarshalHTML

theplant · Sep 14, 2023 · 8f523db · 8f523db
1 parent 3879865
commit 8f523db
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/theplant/htmlgo
 
-go 1.17
+go 1.18
 
 require github.com/theplant/testingutils v0.0.0-20190603093022-26d8b4d95c61
 

diff --git a/tag.go b/tag.go
@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"html"
 	"strings"
+	"sync"
 )
 
 type tagAttr struct {
@@ -267,6 +268,12 @@ func (b *HTMLTagBuilder) PrependChildren(c ...HTMLComponent) (r *HTMLTagBuilder)
 	return b
 }
 
+var bufPool = sync.Pool{
+	New: func() any {
+		return &bytes.Buffer{}
+	},
+}
+
 func (b *HTMLTagBuilder) MarshalHTML(ctx context.Context) (r []byte, err error) {
 	class := strings.TrimSpace(strings.Join(b.classNames, " "))
 	if len(class) > 0 {
@@ -331,7 +338,10 @@ func (b *HTMLTagBuilder) MarshalHTML(ctx context.Context) (r []byte, err error)
 		attrStr = " " + strings.Join(attrSegs, " ")
 	}
 
-	buf := bytes.NewBuffer(nil)
+	buf := bufPool.Get().(*bytes.Buffer)
+	defer bufPool.Put(buf)
+	buf.Reset()
+
 	newline := ""
 
 	if b.omitEndTag {