Gating dApp #767
Merged
Gating dApp #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kkosiorowska
force-pushed
the
gating-dapp-ui
branch
2 times, most recently
from
7e94893
to
b50442d
Compare
kkosiorowska
force-pushed
the
gating-dapp-ui
branch
from
24a4d7a
to
dd1a535
Compare
nkuba
reviewed
Oct 23, 2024
dapp/src/hooks/useAccessCode.ts
Outdated
| import useLocalStorage from "./useLocalStorage" | ||
|
|
||
| export default function useAccessCode() { | ||
| const [accessCode, setAccessCode] = useLocalStorage<string | undefined>( |
There was a problem hiding this comment.
Suggested change
| const [accessCode, setAccessCode] = useLocalStorage<string | undefined>( | |
| const [encodedCode, setAccessCode] = useLocalStorage<string | undefined>( |
r-czajkowski
previously approved these changes
Oct 24, 2024
r-czajkowski
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a gating in dApp. The user must enter access code to access a standalone dApp. The access code entered on the form is checked by a special endpoint
access/verify. When the code is correct, the dApp should allow the user to see dApp. Otherwise, we will show the right error message.What has been done
VITE_FEATURE_GATING_DAPP_ENABLEDfeature flaglocalStorageUI
Screen.Recording.2024-10-22.at.13.09.04.mov