dApp: Action duration estimation & validation #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nkuba
reviewed
Oct 29, 2024
| @@ -37,7 +37,7 @@ const TokenAmountForm = withFormik<TokenAmountFormProps, TokenAmountFormValues>( | |||
| props.onSubmitForm(values) | |||
| }, | |||
| validateOnBlur: false, | |||
| validateOnChange: false, | |||
| validateOnChange: true, | |||
There was a problem hiding this comment.
We wanted to avoid running the validation on any input change for the amount field.
Currently, when you start entering the value starting with 0 you will immediately see the validation error. We want to run the validation when the user exits the input field.
So validateOnBlur seems like a better fit.
There was a problem hiding this comment.
Yeah, I agree. Let's change it.
There was a problem hiding this comment.
Ref commit: 878b1f4
kpyszkowski
changed the title
kkosiorowska
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #789
Changes:
Screen.Recording.2024-10-28.at.15.48.57.mov