-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dApp: Action duration estimation & validation #790
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
795b0c3
Implement `ActionDurationEstimation` component
kpyszkowski 90a6112
Update text colors
kpyszkowski 06fd76a
Merge branch 'main' into deposit-duration-estimation
kpyszkowski 0abf238
Update token amount field value gathering
kpyszkowski 42f78bb
Enable action form validation on change
kpyszkowski 878b1f4
Update validation strategy
kpyszkowski b7f6dd2
Merge branch 'main' into deposit-duration-estimation
kkosiorowska File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25
dapp/src/components/TransactionModal/ActionDurationEstimation.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import React from "react" | ||
import { ActivityType } from "#/types" | ||
import { getEstimatedDuration } from "#/utils" | ||
import { useFormField } from "#/hooks" | ||
import { TextMd } from "../shared/Typography" | ||
import { TOKEN_AMOUNT_FIELD_NAME } from "../shared/TokenAmountForm/TokenAmountFormBase" | ||
|
||
export default function ActionDurationEstimation({ | ||
type, | ||
}: { | ||
type: ActivityType | ||
}) { | ||
const { value: amount = 0n } = useFormField<bigint | undefined>( | ||
TOKEN_AMOUNT_FIELD_NAME, | ||
) | ||
|
||
return ( | ||
<TextMd mt={4} color="grey.400"> | ||
Estimated duration | ||
<TextMd as="span" color="grey.500"> | ||
~ {getEstimatedDuration(amount, type)} | ||
</TextMd> | ||
</TextMd> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wanted to avoid running the validation on any input change for the amount field.
Currently, when you start entering the value starting with
0
you will immediately see the validation error. We want to run the validation when the user exits the input field.So
validateOnBlur
seems like a better fit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree. Let's change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref commit: 878b1f4