Skip to content

Commit

Permalink
Add reply by Gerald Benischke
Browse files Browse the repository at this point in the history
  • Loading branch information
tdpauw committed Feb 13, 2024
1 parent c73d613 commit 061d0c9
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
4 changes: 4 additions & 0 deletions _posts/2022-02-21-a-tribute-to-self.md
Original file line number Diff line number Diff line change
Expand Up @@ -583,3 +583,7 @@ Speaking at the CfgMgmtCamp 2024 single track.
> I've heard Thierry de Pauw speak and I can confirm he is a great speaker who knows his stuff.
>
> -- [Giovanni Asproni](https://www.linkedin.com/in/gasproni/), [Feb 7, 2024](https://www.linkedin.com/feed/update/urn:li:activity:7160363455080775680?commentUrn=urn%3Ali%3Acomment%3A%28activity%3A7160363455080775680%2C7160381079554547712%29&replyUrn=urn%3Ali%3Acomment%3A%28activity%3A7160363455080775680%2C7160986213640757249%29&dashCommentUrn=urn%3Ali%3Afsd_comment%3A%287160381079554547712%2Curn%3Ali%3Aactivity%3A7160363455080775680%29&dashReplyUrn=urn%3Ali%3Afsd_comment%3A%287160986213640757249%2Curn%3Ali%3Aactivity%3A7160363455080775680%29)
> Well, as someone who’s met you and seen you talk: you’ll do fantastic, I like your presentation style and am a super fan of your blog posts, so extrapolating from that: you’ll rock it.
>
> -- [Gerald Benischke](https://www.linkedin.com/in/gerald-benischke-9811b663/), [Feb 11, 2024](https://www.linkedin.com/feed/update/urn:li:activity:7160363455080775680?commentUrn=urn%3Ali%3Acomment%3A%28activity%3A7160363455080775680%2C7162049457893658625%29&dashCommentUrn=urn%3Ali%3Afsd_comment%3A%287162049457893658625%2Curn%3Ali%3Aactivity%3A7160363455080775680%29)
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,22 @@ Once, the team was contacted by internal auditors because we did not follow the

Back then, there was tooling available to support Non-Blocking Reviews:

- With the team, we used [Atlassian Crucible](https://www.atlassian.com/software/crucible). We added in every commit a ticket number. The tool allows grouping all commits based on a ticket number to create a code review. The state of that tool is unclear at the moment.
- With the team, we used [Atlassian Crucible](https://www.atlassian.com/software/crucible). We tagged every commit with the feature ticket number. The tool allows to group all commits based on a ticket number to create a code review. The state of that tool is unclear at the moment.
- JetBrains had a similar tool called [UpSource](https://www.jetbrains.com/upsource/). It has been discontinued.
- There was [Phabricator](https://www.phacility.com/phabricator/) from Facebook. That has also been discontinued.
- There was [Phabricator](https://www.phacility.com/phabricator/) from Facebook. That has also been discontinued. Though, there seem to exist a fork, [Phorge](https://phorge.it).

Although these tools help reach the fast flow of work, vendors are discontinuing these tools in favour of Pull Request-based tooling.

At the 2022 SoCraTes Germany unconference, I met [Tomas Skogberg](https://twitter.com/tskogberg). He works for [Auctionet](https://twitter.com/auctionetdev). Tomas shared they practice trunk-based development for ten years. Being confronted with the same situation, Auctionet decided to implement their own code review tool, [ex-remit](https://github.com/barsoom/ex-remit), for Non-Blocking Reviews which is open sourced.

There is also [Gerrit](), implemented by Guido van Rossum, the creator of Python, for the Android teams at Google.

Recently, I discovered [ReviewBoard]() which seems to work in a similar way as Atlassian Crucible.

## No Tooling

But, in all truth, we do not necessarily need any tooling for running code reviews. An engineer can as well guide the team through the code and have a discussion. Though, if we need an audit-trail of reviews, tooling will help.

## Definitions

### Mainline
Expand Down

0 comments on commit 061d0c9

Please sign in to comment.