Fix nasa#262, Update inaccurate event ID name

thnkslprpt · Dec 14, 2023 · 1a3de4e · 1a3de4e
1 parent 515e3a8
commit 1a3de4e
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/fsw/inc/cf_events.h b/fsw/inc/cf_events.h
@@ -132,7 +132,7 @@
  *
  *  Invalid message ID received on the software bus pipe
  */
-#define CF_EID_ERR_INIT_CMD_LENGTH (28)
+#define CF_MID_ERR_EID (28)
 
 /**
  * \brief CF SB Receive Buffer Failed Event ID

diff --git a/fsw/src/cf_app.c b/fsw/src/cf_app.c
@@ -302,8 +302,8 @@ void CF_ProcessMsg(CFE_SB_Buffer_t *msg)
 
         default:
             ++CF_AppData.hk.Payload.counters.err;
-            CFE_EVS_SendEvent(CF_EID_ERR_INIT_CMD_LENGTH, CFE_EVS_EventType_ERROR,
-                              "CF: invalid command packet id=0x%lx", (unsigned long)CFE_SB_MsgIdToValue(msg_id));
+            CFE_EVS_SendEvent(CF_MID_ERR_EID, CFE_EVS_EventType_ERROR, "CF: invalid command packet id=0x%lx",
+                              (unsigned long)CFE_SB_MsgIdToValue(msg_id));
             break;
     }
 }

diff --git a/fsw/src/cf_cfdp_types.h b/fsw/src/cf_cfdp_types.h
@@ -162,7 +162,6 @@ typedef enum
 
     /* keep last */
     CF_TxnStatus_MAX = 22
-
 } CF_TxnStatus_t;
 
 /**

diff --git a/unit-test/cf_app_tests.c b/unit-test/cf_app_tests.c
@@ -577,7 +577,7 @@ void Test_CF_ProcessMsg_UnrecognizedCommandEnterDefaultPath(void)
     /* Assert */
     UtAssert_UINT32_EQ(CF_AppData.hk.Payload.counters.err, 1);
     UtAssert_STUB_COUNT(CFE_EVS_SendEvent, 1);
-    UT_CF_AssertEventID(CF_EID_ERR_INIT_CMD_LENGTH);
+    UT_CF_AssertEventID(CF_MID_ERR_EID);
 }
 
 /*******************************************************************************