Add MongoDB example that works with prestarted MongoDB #196
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
https://ci.wildfly-swarm.io/job/thorntail-examples-pull-request-linux might need some changes, will see what happens with this pr testing first! For local testing, I used Docker to start MongoDB. |
scottmarlow
force-pushed
the
mongodb2
branch
from
b4217ce to
11b77bf
Compare
| <artifactId>example-microprofile-nosql</artifactId> | ||
|
|
||
| <name>Thorntail Examples: Microprofile NoSQL</name> | ||
| <description>Thorntail Examples: Microprofile NoSQL</description> |
There was a problem hiding this comment.
Microprofile -> MicroProfile
| </services> | ||
| </resources> | ||
| </configuration> | ||
| </execution> |
There was a problem hiding this comment.
I don't quite understand why this entire <execution> is needed. Seems to me your usage of FMP is unnecessarily complicated.
| from: | ||
| kind: ImageStreamTag | ||
| name: example-microprofile:latest | ||
| type: ImageChange |
There was a problem hiding this comment.
It seems the only thing you do here is specifying -Dswarm.project.stage. You don't need to add the full YAML, just what you need to add, FMP will generate the rest.
| targetPort: 8080 | ||
| to: | ||
| kind: Service | ||
| name: example-microprofile |
There was a problem hiding this comment.
I think FMP would generate the same thing.
| targetPort: 8080 | ||
| selector: | ||
| deploymentconfig: example-microprofile | ||
| type: LoadBalancer |
There was a problem hiding this comment.
I think FMP would generate the same thing.
| public class MyResource { | ||
|
|
||
| @Inject @Named("mongodbtestprofile") | ||
| MongoDatabase database; |
| @Override | ||
| public Response toResponse(NotFoundException e) { | ||
| return Response | ||
| .status(Response.Status.OK) |
|
Thanks for the review, I hope to spend more time on this soon, I also want to see if I can improve the password handling a bit also, to use a generated password instead of hard coding it. |
|
add to whitelist |
No description provided.