API Detailed Operations Tutorial Streams and Group Sets #10

Shyamachandran · 2024-08-01T11:14:42Z

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as
expected)
Documentation (update or new)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

Testing Checklist

Tested in latest Chrome
Tested in latest Safari
Tested in latest Firefox

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have requested a review from ... on the Pull Request

netlify · 2024-08-01T11:14:58Z

✅ Deploy Preview for ontrackdocumentation ready!

Name	Link
🔨 Latest commit	`009879f`
🔍 Latest deploy log	https://app.netlify.com/sites/ontrackdocumentation/deploys/66e928e213b35d00088b9fb8
😎 Deploy Preview	https://deploy-preview-10--ontrackdocumentation.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

minusunil

Can you please format the file using prettier

Shyamachandran · 2024-08-04T10:03:04Z

Hi Minu, Thanks for your review.
I have updated the file with appropriate formatting.

minusunil

Hey Shyama, I've reviewed the changes you've made, and they are clear and good

DudeUnleashed

Hi Shyama, there's a few problems with the formatting of the page, and names of some of your parameters as mentioned in my various comments, however the endpoints, requests and everything else seem correct.

src/content/docs/backend/API/unit-tutorial_streams.md

package-lock.json

DudeUnleashed

The changes I requested have been made, everything looks good. The package-lock.json seems to be a bunch of updates, not sure if this needs to be done or ignored for the future.

minusunil

Operations of "group_sets" API endpoints looks good, and formatting is also done

minusunil

Documentation for these endpoints looks good and clear

aNebula · 2024-09-03T09:29:30Z

The changes I requested have been made, everything looks good. The package-lock.json seems to be a bunch of updates, not sure if this needs to be done or ignored for the future.

package-lock.json are to be committed, as they lock the versions of the dependencies. Thanks for the thorough review.

aNebula

Please remove the merge conflict from astro.config.mjs

aNebula · 2024-09-03T09:31:47Z

astro.config.mjs

+<<<<<<< HEAD
+              label: 'Tutorial Streams',
+              link: '/backend/api/Unit-Tutorial Streams.md',
+            },
+            {
+              label: 'Group sets',
+=======
+              label: 'Unit Tutorial Streams',
+              link: '/backend/api/unit-tutorial_streams',
+            },
+            {
+              label: 'Unit Group Sets',
+>>>>>>> 07d8b8ad5447c02473126889dd785e6219e6c300


@Shyamachandran this is merge conflict - please remove this and get a re-review from @DudeUnleashed .

Change the PR title too please.

Hello Nebula, Thank you for your review.
I have made the necessary changes and is ready for your review.
@DudeUnleashed - Please review revised version.

Hi Nebula,
This is all done now. All conflicts addressed.

DudeUnleashed

There are some adjustments to be made, mainly for clarity on some of the parameters, and one formatting error for a response, all have been commented on, please take a look and see what you think.

src/content/docs/backend/API/unit-group_sets.md

DudeUnleashed

Everything that i brought up in previous review has been looked at, the deployment preview looks good for this section. Good work.

DudeUnleashed · 2024-09-16T06:58:37Z

@Shyamachandran There is a conflict you have to address first in the astro.config.mjs, please fix these and then we can move forward, thanks.

Shyamachandran · 2024-09-17T08:37:43Z

Hi Jake,
Conflicts resolved.

Shyamachandran added 3 commits July 20, 2024 22:07

Test API added

ca5d9a8

Test API

a908734

unit Tutorial streams updated in New folder

6c33254

minusunil suggested changes Aug 4, 2024

View reviewed changes

Formatted content

41bb4dc

changes astro file

c397732

minusunil approved these changes Aug 4, 2024

View reviewed changes

aNebula requested a review from DudeUnleashed August 6, 2024 08:34

DudeUnleashed requested changes Aug 8, 2024

View reviewed changes

Shyamachandran added 3 commits August 11, 2024 15:48

unit Tutorial streams updated

df5b1ce

unit group sets updated in new folder

510979c

Update unit-group_sets.md

07d8b8a

DudeUnleashed reviewed Aug 22, 2024

View reviewed changes

DudeUnleashed approved these changes Aug 22, 2024

View reviewed changes

minusunil approved these changes Aug 22, 2024

View reviewed changes

Shyamachandran added 2 commits September 1, 2024 12:22

added more API operations into the folder

10c4bb9

added new API under group sets folder

2cfae46

minusunil approved these changes Sep 3, 2024

View reviewed changes

aNebula requested changes Sep 3, 2024

View reviewed changes

Shyamachandran added 2 commits September 3, 2024 21:16

Update unit-group_sets.md

c9d214f

Update astro.config.mjs

d77bda9

Shyamachandran changed the title ~~Sh/ap iupdate~~ API Detailed Operations Tutorial Streams and Group Sets Sep 3, 2024

DudeUnleashed requested changes Sep 8, 2024

View reviewed changes

Update unit-group_sets.md

e49ff0f

DudeUnleashed reviewed Sep 16, 2024

View reviewed changes

DudeUnleashed approved these changes Sep 16, 2024

View reviewed changes

Shyamachandran and others added 3 commits September 16, 2024 20:11

Update astro.config.mjs

e89f0db

Update astro.config.mjs

ec93941

Merge branch 'main' into sh/APIupdate

009879f

aNebula approved these changes Sep 18, 2024

View reviewed changes

aNebula merged commit 4973907 into thoth-tech:main Sep 18, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API Detailed Operations Tutorial Streams and Group Sets #10

API Detailed Operations Tutorial Streams and Group Sets #10

Shyamachandran commented Aug 1, 2024

netlify bot commented Aug 1, 2024 •

edited

Loading

minusunil left a comment

Shyamachandran commented Aug 4, 2024

minusunil left a comment

DudeUnleashed left a comment

DudeUnleashed left a comment

minusunil left a comment

minusunil left a comment

aNebula commented Sep 3, 2024

aNebula left a comment

aNebula Sep 3, 2024

aNebula Sep 3, 2024

Shyamachandran Sep 3, 2024

Shyamachandran Sep 17, 2024

DudeUnleashed left a comment

DudeUnleashed left a comment

DudeUnleashed commented Sep 16, 2024

Shyamachandran commented Sep 17, 2024

API Detailed Operations Tutorial Streams and Group Sets #10

API Detailed Operations Tutorial Streams and Group Sets #10

Conversation

Shyamachandran commented Aug 1, 2024

Description

Type of change

How Has This Been Tested?

Testing Checklist

Checklist

netlify bot commented Aug 1, 2024 • edited Loading

✅ Deploy Preview for ontrackdocumentation ready!

minusunil left a comment

Choose a reason for hiding this comment

Shyamachandran commented Aug 4, 2024

minusunil left a comment

Choose a reason for hiding this comment

DudeUnleashed left a comment

Choose a reason for hiding this comment

DudeUnleashed left a comment

Choose a reason for hiding this comment

minusunil left a comment

Choose a reason for hiding this comment

minusunil left a comment

Choose a reason for hiding this comment

aNebula commented Sep 3, 2024

aNebula left a comment

Choose a reason for hiding this comment

aNebula Sep 3, 2024

Choose a reason for hiding this comment

aNebula Sep 3, 2024

Choose a reason for hiding this comment

Shyamachandran Sep 3, 2024

Choose a reason for hiding this comment

Shyamachandran Sep 17, 2024

Choose a reason for hiding this comment

DudeUnleashed left a comment

Choose a reason for hiding this comment

DudeUnleashed left a comment

Choose a reason for hiding this comment

DudeUnleashed commented Sep 16, 2024

Shyamachandran commented Sep 17, 2024

netlify bot commented Aug 1, 2024 •

edited

Loading