Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation for admin,tasks,submission,tii_actions #9

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

minusunil
Copy link
Contributor

@minusunil minusunil commented Jul 28, 2024

Description

Changes include detailed pages for each backend doubtfire API and completed documentation for API_Set5

  1. admin
  2. submission
  3. task
  4. tii_actions

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

Testing Checklist

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

Copy link

netlify bot commented Jul 28, 2024

Deploy Preview for ontrackdocumentation ready!

Name Link
🔨 Latest commit 01f6ca3
🔍 Latest deploy log https://app.netlify.com/sites/ontrackdocumentation/deploys/66b87b0f2ad0ce0008cadaf2
😎 Deploy Preview https://deploy-preview-9--ontrackdocumentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Shyamachandran Shyamachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Minu,
As per my review on the backend code, this looks good and understandable.

@aNebula aNebula requested review from Shyamachandran and DudeUnleashed and removed request for Shyamachandran August 6, 2024 08:12
Copy link
Collaborator

@DudeUnleashed DudeUnleashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks correct except the issue in the admin file i left a comment on, everything fits the same layout as the other documentation throughout the site.

src/content/docs/backend/API/admin.md Show resolved Hide resolved
Copy link
Collaborator

@DudeUnleashed DudeUnleashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good now, things mentioned were fixed

Copy link
Collaborator

@aNebula aNebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aNebula aNebula merged commit ae09ab7 into thoth-tech:main Sep 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants