Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace fxLayout with tailwind equivalent - edit-profile-form component #124

Conversation

williamalowe
Copy link

Description

Replaced depreciated fxLayout library implemented with equivalent Tailwindcss for edit-profile-form component.

Type of change

How Has This Been Tested?

before:
edit-profile-form-new-user-no-changes
edit-profil-form-component-no-changes-80

after:
edit-profile-more-new-user-tailwind
edit-profile-form-component-tailwind

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@williamalowe
Copy link
Author

MINH THO DUONG will be reviewing this

@s223749059
Copy link

Peer review is completed for this pull request. The OnTrack application runs in my machine. Edit profile form component is identified correctly in code and in webpage (for Set up profile and Create account mode). All fx-Layout are removed. When applying tailwind, the before and after webpage look the same. There is no testing for create account mode as the application does not run after reset up.

@williamalowe
Copy link
Author

fixed commented out line on line 53

@maddernd
Copy link

This one is good to go for upstream creation to doubtfire-lms

@maddernd maddernd closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants