-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration: confirmation-modal component #148
base: development
Are you sure you want to change the base?
Migration: confirmation-modal component #148
Conversation
Tested locally and everything seems good. @satikaj Can you double check the code? |
The before and after image seem to have different formatting, it will need adjusting to look the same as the before image. |
ce8ff9d
to
e3e1da0
Compare
The confirmation-model component GUI is updated regarding to the peer-review comments. |
Tested this locally and everything seems to be functioning correctly. No perceptible visual changes after the migration. Good work. |
Looks good to me. |
Description
Migrate the confirmation-modal component from CoffeeScript and Angular.js to TypeScript and Angular. The component is used at unit-tutorials-list component. It creates a confirmation dialog when users decide to delete a unit task. The action can be performed under aconvenor and aadmin account privileges.
How Has This Been Tested?
Before:
After:
Testing Checklist:
Checklist: