Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: confirmation-modal component #148

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

s223749059
Copy link

@s223749059 s223749059 commented Mar 19, 2024

Description

Migrate the confirmation-modal component from CoffeeScript and Angular.js to TypeScript and Angular. The component is used at unit-tutorials-list component. It creates a confirmation dialog when users decide to delete a unit task. The action can be performed under aconvenor and aadmin account privileges.

How Has This Been Tested?

  • First, log in as aconvenor or aadmin acount.
  • Under the Administration section, select Units.
  • After choosing a specific unit name, select the Tasks tab.
  • In that, there is a list of unit tasks. Click on the red delete icon, it displays the confirmation dialog. Users can perform delete actions and receive alert messages on the top right hand side.

Before:

SIT782 confirmation-modal (before)

After:

SIT782 confirmation-model (after) - update GUI
  • Successful delete a unit task:
SIT782 confirmation-modal - delete action (success)
  • Error handling:
SIT782 confirmation-modal - delete action (error handling)

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@ublefo
Copy link
Collaborator

ublefo commented Mar 26, 2024

Tested locally and everything seems good. @satikaj Can you double check the code?

@maddernd
Copy link

maddernd commented Apr 6, 2024

The before and after image seem to have different formatting, it will need adjusting to look the same as the before image.

@s223749059 s223749059 force-pushed the migration/confirmation-modal-exercise branch from ce8ff9d to e3e1da0 Compare April 14, 2024 07:10
@s223749059
Copy link
Author

The confirmation-model component GUI is updated regarding to the peer-review comments.

@ublefo
Copy link
Collaborator

ublefo commented Apr 17, 2024

Tested this locally and everything seems to be functioning correctly. No perceptible visual changes after the migration. Good work.

@aNebula
Copy link

aNebula commented May 11, 2024

Looks good to me.
Please recreate this Pull Request against the development branch of upstream repo doubtfire-lms/doubtfire-web. This is the final step for upstream merge.
You will likely face some conflicts in the src/app/doubtfire-angular.module.ts src/app/doubtfire-angularjs.module.ts files if you try to push the current changes. You could resolve those conflict then or you could potentially avoid conflict if you clone that repo first and copy across your particular changes and then raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants