Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Task Def model and service to keep track of Numbas config #150

Merged

Conversation

satikaj
Copy link
Collaborator

@satikaj satikaj commented Mar 22, 2024

Description

Fixed the bug where although the Numbas test was uploaded, the delete and download buttons did not show in the editor on refresh. The other config options are also now stored in the backend (corresponding doubtfire-api PR: thoth-tech/doubtfire-api#16).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Opening the task editor as a convenor, you can upload and configure Numbas tests.

Before:

Although a test was uploaded and configured, the form would be blank on refresh:

image

After:

image

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@ublefo
Copy link
Collaborator

ublefo commented Mar 22, 2024

Tested and it's all working well, two things that we could improve:

  1. Hide all options in the numbas component if it's disabled to reduce visual clutter
  2. Disable numbas test automatically when saving the task definition if the test data is not uploaded or has been deleted.

@maddernd maddernd merged commit 696abc0 into thoth-tech:add-numbas-integration Mar 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants