Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New/feedback enhancement stage service #209

Conversation

coskun-kilinc
Copy link

Description

This pull request introduces the stage service to the Doubtfire Web repository. The main changes include the addition of the stage service, updating the task definition model and component to use the stage service calls, and making various improvements and fixes related to the task definition stages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The changes have been tested manually to ensure compatibility and stability. The testing process included:

  1. Functional testing of the new stage service.
  2. Verification of the task definition model and component using the stage service calls.
  3. Testing the API calls to ensure they use the correct endpoints in the stage service.
  4. Ensuring the updated stage type definitions in TaskDefinition work as expected.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @satikaj and @maddernd on the Pull Request

coskun-kilinc and others added 30 commits March 25, 2024 10:51
Adds feedbacks tages component to task definitions for tutor feedback
enhancement feature.
adds feedbackstage type declaration in task
definition as well as a new stage property
Replaces placeholder stage functionality with corresponding function in
the stage service which interact correctly with the backend# Please enter
 the commit message for your changes. Lines starting
The code changes remove the unused `stages` array and related methods in
the TaskDefinition model. This improves the code by removing unnecessary
code that is not being used.
Replaces placeholder stage functionality with corresponding function in
the stage service which interact correctly with the backend# Please enter
 the commit message for your changes. Lines starting
The code changes remove the empty `stages` array in the
`UnitTaskEditorComponent` file. This change is made to improve the code
by removing unnecessary code that is not being used.
The code changes remove the unused `stages` array and related methods in
the TaskDefinition model. This improves the code by removing unnecessary
code that is not being used.
This commit corrects an error the TaskDefinitionStagesComponent by adding
a call to the `renderRows()` method after pushing a new stage to the
`stages` array. This ensures that the table is updated with the new
stage immediately. The change improves the user experience by providing
real-time updates when adding stages to the task definition.
@maddernd maddernd merged commit 561c3e5 into thoth-tech:new-feedback-enhancement May 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants