forked from doubtfire-lms/doubtfire-web
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New/feedback enhancement stage service #209
Merged
maddernd
merged 31 commits into
thoth-tech:new-feedback-enhancement
from
coskun-kilinc:new/feedback-enhancement-stage-service
May 17, 2024
Merged
New/feedback enhancement stage service #209
maddernd
merged 31 commits into
thoth-tech:new-feedback-enhancement
from
coskun-kilinc:new/feedback-enhancement-stage-service
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds feedbacks tages component to task definitions for tutor feedback enhancement feature.
adds feedbackstage type declaration in task definition as well as a new stage property
This reverts commit d1d8c72.
Replaces placeholder stage functionality with corresponding function in the stage service which interact correctly with the backend# Please enter the commit message for your changes. Lines starting
The code changes remove the unused `stages` array and related methods in the TaskDefinition model. This improves the code by removing unnecessary code that is not being used.
Replaces placeholder stage functionality with corresponding function in the stage service which interact correctly with the backend# Please enter the commit message for your changes. Lines starting
The code changes remove the empty `stages` array in the `UnitTaskEditorComponent` file. This change is made to improve the code by removing unnecessary code that is not being used.
The code changes remove the unused `stages` array and related methods in the TaskDefinition model. This improves the code by removing unnecessary code that is not being used.
This commit corrects an error the TaskDefinitionStagesComponent by adding a call to the `renderRows()` method after pushing a new stage to the `stages` array. This ensures that the table is updated with the new stage immediately. The change improves the user experience by providing real-time updates when adding stages to the task definition.
maddernd
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the stage service to the Doubtfire Web repository. The main changes include the addition of the stage service, updating the task definition model and component to use the stage service calls, and making various improvements and fixes related to the task definition stages.
Type of change
How Has This Been Tested?
The changes have been tested manually to ensure compatibility and stability. The testing process included:
Testing Checklist:
Checklist: