Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fx-layout with tailwind equivalent -task-dashboard #81

Closed

Conversation

caoquocvinq
Copy link

@caoquocvinq caoquocvinq commented Aug 17, 2023

Any italic text should be deleted from the final Pull Request text, including this line

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

@caoquocvinq
Copy link
Author

Changing the fx Layout with tailwind equivalent:
Before:
Before
After:
After

@maddernd
Copy link

This can now be recreated in the upstream Repo for final review ( doubtfire-lms/doubtfire-web) please leave these PR open too.

@maddernd
Copy link

Ok this looks good, thanks for sending it through. Please can you now create these same Pull request on the upstream repo doubtfire-lms/doubtfire-web, please ensure that you follow contirbuting.md for making sure the PR meets the requirements for a pull request. Once you have made the PR into the upstream we will move the Trello card into Review Upstream.

@maddernd maddernd closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants