Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tailwind equivalent unit dropdown #85

Conversation

jayant31j
Copy link

As part of front-end migration. I migrated all the fx-layout fields to tailwind classes

Changes made:
Used tailwind components to replace the older fx-layout component in html file of Unit dropdown.

Description

Replaced fx-layout components of the Unit dropdown to tailwind. The unit dropdown can be seen from the tutor and student ontrack systems.

  • Before Screenshot:
Before
  • After screenshot
After

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

@jayant31j jayant31j marked this pull request as ready for review September 3, 2023 15:29
@maddernd
Copy link

I have made an upstream PR for this one.

@maddernd
Copy link

This does not work, none of the styling is applied correctly based on this PR and it does not match the screenshots.

@maddernd maddernd closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants