Update e2e.py #71
Open
Update e2e.py #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preventing UnicodeDecodeError in case that Umlaute, etc. are in e.g., an images description.
|
Oof, nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing UnicodeDecodeError in case that Umlaute, etc. are in e.g., an images description.
Original error-message read:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/threema/gateway/e2e.py", line 1300, in unpack
content = bytes(reader.readexactly(len(reader))).decode('ascii')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 259: ordinal not in range(128)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/python-docker/app.py", line 125, in handle_callback
message = await e2e.Message.receive(connection, {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/threema/gateway/e2e.py", line 506, in receive
return await class_.unpack(connection, parameters, key_pair, reader)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/threema/gateway/e2e.py", line 1302, in unpack
raise MessageError('Could not decode JSON') from exc
threema.gateway.exception.MessageError: Could not decode JSON