Add tBTC SDK Page #105
Add tBTC SDK Page #105
Conversation
|
Preview uploaded to https://preview.threshold.network/tbtc-sdk-page/index.html. |
|
Preview uploaded to https://preview.threshold.network/tbtc-sdk-page/index.html. |
|
Preview uploaded to https://preview.threshold.network/tbtc-sdk-page/index.html. |
|
Preview uploaded to https://preview.threshold.network/tbtc-sdk-page/index.html. |
|
Preview uploaded to https://preview.threshold.network/tbtc-sdk-page/index.html. |
|
Preview uploaded to https://preview.threshold.network/tbtc-sdk-page/index.html. |
|
Preview uploaded to https://preview.threshold.network/tbtc-sdk-page/index.html. |
| <Container | ||
| maxW="1140px" | ||
| h="100%" | ||
| display="flex" | ||
| justifyContent="space-between" | ||
| > |
There was a problem hiding this comment.
Non-blocking:
I think that the NavBar would require some refactoring/touch-ups, because in some resolutions it looks off. For example this is how it looks for 1173px width:
I think that setting the maxW to 1140px with justifyContent="space-between" is a mistake. Content should probably just be justified to "center" and the width should be maxed out. But I'm not sure as of now.
I think this would require some more touch upd in the long run so I would say to address this issue in a separate PR. The bug is also happening on production (1126 px width):
but adding the dashboard link in the navigation made it a little bit worse (see previous screen).
To not block this PR, I will mark it as non-blocking. Addressing that issue in this PR might extend the time to merge this one, as more code equals to more potential bugs that can be found 😅 So I would say we separate that into another PR. Let's just not forget about that issue..
You can test it out yourself and see it you can reproduce the issue.
There was a problem hiding this comment.
Good catch! I've opened an issue to keep track of that, I will address it in a separate PR as advised.
Issue: #107
There was a problem hiding this comment.
Great! I'll keep this conversation open just in case
|
Preview uploaded to https://preview.threshold.network/tbtc-sdk-page/index.html. |
Description
Add the tBTC SDK landing page to the website with multiple sections - Updated navbar to accommodate a new category for the upcoming Threshold products, starting with the tBTC SDK (thUSD and TACo).
Figma's design prototype: https://www.figma.com/file/5eN3hPMkCVOpXb5YQw6CtB/tBTC-SDK?type=design&node-id=1264%3A185&mode=design&t=btHMRHkFwM2x8nJN-1
Notice
Pull Request Type
Issue (if applicable)
Closes issue #90
Testing
Please outline all testing steps
Screenshots (if applicable)
For mobile: