Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tBTC SDK Page #105
Add tBTC SDK Page #105
Changes from all commits
b03599a
5a7ff4c
727d526
d602fb0
354fdc5
d681d1e
03bf45c
02522d9
2af0b4d
896955e
881ed9c
f6273f7
8775651
98ae297
f0df2bb
c13f9b5
e69a16e
8b7e3bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking:
I think that the
NavBar
would require some refactoring/touch-ups, because in some resolutions it looks off. For example this is how it looks for1173px
width:I think that setting the maxW to
1140px
withjustifyContent="space-between"
is a mistake. Content should probably just be justified to "center" and the width should be maxed out. But I'm not sure as of now.I think this would require some more touch upd in the long run so I would say to address this issue in a separate PR. The bug is also happening on production (1126 px width):
but adding the dashboard link in the navigation made it a little bit worse (see previous screen).
To not block this PR, I will mark it as non-blocking. Addressing that issue in this PR might extend the time to merge this one, as more code equals to more potential bugs that can be found 😅 So I would say we separate that into another PR. Let's just not forget about that issue..
You can test it out yourself and see it you can reproduce the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I've opened an issue to keep track of that, I will address it in a separate PR as advised.
Issue: #107
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I'll keep this conversation open just in case