WIP: PMU data collection #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengly123
requested changes
Jul 29, 2023
Closed
zhengly123
requested changes
Jul 30, 2023
src/CollectorPapi.cc
Outdated
Comment on lines
4
to
12
| #define checkPapi(call,stdpapi) \ | ||
| { \ | ||
| auto err = call; \ | ||
| if (stdpapi != err) { \ | ||
| fprintf(stderr, "PAPI error in %s:%i : %s.\n", __FILE__, __LINE__, \ | ||
| PAPI_strerror(retval)); \ | ||
| exit(EXIT_FAILURE); \ | ||
| } \ | ||
| } |
There was a problem hiding this comment.
This macro is already defined in include/collector_papi.h. This overload with two paramters seems to be seldom used as most of the return values are PAPI_OK. I suggest using the original papiCheck without a custom return value.
zhengly123
reviewed
Jul 31, 2023
zhengly123
reviewed
Aug 1, 2023
src/CollectorPapi.cc
Outdated
| // and papi_start_counters() in deprecated/pmc.cpp. | ||
| int retval = 0; | ||
| EventSet = PAPI_NULL; | ||
| PAPI_library_init(PAPI_VER_CURRENT); |
There was a problem hiding this comment.
Should we check the return value?
test/test_collector.cc
Outdated
Comment on lines
41
to
43
| int *test_data = new int[N]; | ||
|
|
||
| int test_index[N]; | ||
| int *test_index = new int[N]; |
There was a problem hiding this comment.
Use vector or shared_ptr
|
stg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new