Switch Messages choose folder and create doc to Activity Result API

[marcRDZ]

Change related to #7758

Migrate choose folder and create doc results to new API on message screens

[cketti]

Please note that you can run the detekt Gradle task locally to be notified of the code quality issues that will fail the CI build if not addressed.

[marcRDZ]

Yes, I ran spotless but not detekt, I just remove a unused enum class but for the too large class problem I have to consider options.
I've extracted MessageViewFragmentListener on a different file but the task is still failing.

[cketti]

MessageViewFragment was too large before. This was ignored via detekt's baseline mechanism. Fixing this detekt error by splitting apart MessageViewFragment is outside the scope of this pull request. Please suppress the error by using @Suppress("LargeClass").

In general, please try to focus a pull request on one thing. If you have to do some refactoring to make the actual change easier, that's fine, but make it a separate commit. If it's a lot of refactoring, that should be split out to a separate pull request (or even multiple). That will both make it easier to review and easier to understand what was going on should the need arise to look at the Git history at some point in the future.

My suggestion for this pull request:

• A commit for the renaming of launcher properties (this is a pure refactoring without behavior change). Ideally, this would have happened in a different pull request. It's unrelated to the immediate focus of the pull request.
• A commit for the CreateDocumentResultContract change
• A commit for the ChooseFolderResultContract changes
• A commit for extracting MessageViewFragmentListener. Although you could also drop this. It's a good refactoring. But without the context from the comments in this pull request the question "why was this seemingly unrelated change part of that pull request" would be immediately on my mind.

Having small commits makes it easier to review changes and spot e.g. unintentional behavior changes. Especially in this case where e.g. the CreateDocumentResultContract and ChooseFolderResultContract code consist of multiple interspersed changes in the files.
Of course it's always a balance. You could have separate commits for picking the folder for copy and move operations. But since those two are closely related and share some code, it's better to change them both at the same time. So aim for small commits, but not too small 😄

You've already spent quite some time on this. If the requested changes require more time than you'd like to spend, please let me know and I'll break the commit apart for you.

[marcRDZ]

No problem at all, next PR will require less time to be resolved as I'm learning your rules and practices. If I was busier on my job I couldn't spend any time here. 😄
The only strange question I find it's why detekt doesn't complain on MessageViewFragment before my PR.