Skip to content

Commit

Permalink
calendar: Remove a few unneeded TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
kewisch committed Aug 7, 2024
1 parent 4ba2abc commit 6ad8b24
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions calendar/experiments/calendar/ext-calendar-utils.sys.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export function getCachedCalendar(calendar) {
}

export function isCachedCalendar(id) {
// TODO make this better
return id.endsWith("#cache");
}

Expand All @@ -69,7 +68,6 @@ export function convertCalendar(extension, calendar) {
};

if (isOwnCalendar(calendar, extension)) {
// TODO find a better way to define the cache id
props.cacheId = calendar.superCalendar.id + "#cache";
props.capabilities = unwrapCalendar(calendar.superCalendar).capabilities; // TODO needs deep clone?
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ this.calendar_calendars = class extends ExtensionAPI {
.map(calendar => convertCalendar(context.extension, calendar));
},
async get(id) {
// TODO find a better way to determine cache id
if (id.endsWith("#cache")) {
let calendar = unwrapCalendar(cal.manager.getCalendarById(id.substring(0, id.length - 6)));
let own = calendar.offlineStorage && isOwnCalendar(calendar, context.extension);
Expand Down

0 comments on commit 6ad8b24

Please sign in to comment.