Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many new calendar features #34

Merged
merged 17 commits into from
Sep 11, 2024
Merged

Conversation

kewisch
Copy link
Member

@kewisch kewisch commented Aug 7, 2024

I've been busy :D

The commits are each pretty small, if you prefer an easier review go commit by commit.

@kewisch kewisch requested a review from jobisoft August 7, 2024 21:53
@kewisch
Copy link
Member Author

kewisch commented Aug 8, 2024

Please hold, some stuff isn't right.

@kewisch
Copy link
Member Author

kewisch commented Aug 8, 2024

Merge #35 first, this builds on it. Ready to go otherwise.

@jobisoft
Copy link
Collaborator

Could you rebase the PR? I will try to review it before Dublin.

@kewisch
Copy link
Member Author

kewisch commented Aug 10, 2024

No pressure, after Dublin would be fine just as well

Copy link
Collaborator

@jobisoft jobisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through this line by line and did not see obvious mishaps. I do not have the knowledge about the calendar code to be of real help. I guess we will see issues when this is being used :-)

One thing which I think we talked about already is the onAdvanceNewCalendar event. I do not know if the wizard should be part of the API, or if it should be just a content page which can signal "done" by transmitting the settings once the user finished entering the data. This is of course not blocking this PR, maybe just something to keep in mind to re-visit later.

@kewisch
Copy link
Member Author

kewisch commented Sep 11, 2024

Yes, the onAdvanceNewCalendar thing should be revisited. I'm not completely happy with it. We could just give the whole surface to the add-on after initial steps, they'd still need to signal completion in some way. Let's discuss that later down the line, and as there is more clarity on how a potential new calendar dialog could look like.

@kewisch kewisch merged commit cf0c3b5 into thunderbird:main Sep 11, 2024
1 check passed
@kewisch kewisch deleted the calendar-features branch September 11, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants