Remove extra eslintrc and fix style #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobisoft
reviewed
Aug 8, 2024
|
So indent was also not enabled by mozilla/recommended. I do wonder what other fairly obvious rules might not be enabled then. I don't really want to go back to the mega eslintrc. Do you want to do this piece by piece, or do an audit of all rules? |
|
I would like to review this as it is. If we find issues later, we can always file a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an extra eslintrc in the calendar directory which was blocking some rules. I didn't pull all the rules over, strangely there are some pretty basic rules that don't seem to be enabled in the recommended set, but I need to stop somewhere :)