Finding Python types for Columns

[jenstroeger]

Hi, thanks for this function just as I started putting together one of my own. Regarding this code:

pydantic-sqlalchemy/pydantic_sqlalchemy/main.py

Lines 24 to 30 in 8667e21

	python_type: Optional[type] = None
	if hasattr(column.type, "impl"):
	if hasattr(column.type.impl, "python_type"):
	python_type = column.type.impl.python_type
	elif hasattr(column.type, "python_type"):
	python_type = column.type.python_type
	assert python_type, f"Could not infer python_type for {column}"

Have you looked at the typing.get_type_hints() function? Perhaps

else:
    python_types = typing.get_type_hints(db_model)
    python_type = python_types[column.name]

works for you as well?

[ljluestc]

from sqlalchemy.sql import sqltypes
import typing

...

def python_type_for_column(db_model, column):
# Check if the column type is in SQLAlchemy's type map
if isinstance(column.type, sqltypes.TypeEngine):
python_type = column.type.python_type
else:
python_types = typing.get_type_hints(db_model)
python_type = python_types[column.name]
return python_type

[tiangolo]

Thanks for the patience with my reply! 😅

I deprecated this library a while ago in favor of SQLModel which would solve all the same use cases in a much better way, and I'm directing all the effort in that direction.

SQLModel uses Pydantic models to define both data and table (SQL) models, so it's easier to do all these things. 🚀

That also means it uses all the nice type annotations utils from Pydantic. 🤓