Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant syntax #44

Closed
chihchenghuang opened this issue Jun 5, 2020 · 1 comment
Closed

Remove redundant syntax #44

chihchenghuang opened this issue Jun 5, 2020 · 1 comment

Comments

@chihchenghuang
Copy link

little things.
I noticed you used virtual package in the alpine dockerfile.
As I know, once you use this feature, you don't have to list all packages in the apk del command.
apk del .build-deps should work perfect here.

https://github.com/tiangolo/uvicorn-gunicorn-docker/blob/master/docker-images/python3.7-alpine3.8.dockerfile#L7

more discussions:
https://stackoverflow.com/questions/46221063/what-is-build-deps-for-apk-add-virtual-command/46222036

Inpired a lot by your repo. good job man!

@tiangolo
Copy link
Owner

Thank you! And sorry for the very long delay. 😅

At some point I deprecated Alpine. 😅 And now that Uvicorn supports managing workers with --workers, including restarting dead ones, there's no need for Gunicorn. That also means that it's much simpler to build a Docker image from scratch now, I updated the docs to explain it.

Because of that, I deprecated this Docker image: https://github.com/tiangolo/uvicorn-gunicorn-docker#-warning-you-probably-dont-need-this-docker-image

Repository owner locked and limited conversation to collaborators Aug 25, 2024
@tiangolo tiangolo converted this issue into discussion #232 Aug 25, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants