Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi arch builds #47

Closed
mnorrsken opened this issue Aug 9, 2020 · 3 comments
Closed

Multi arch builds #47

mnorrsken opened this issue Aug 9, 2020 · 3 comments

Comments

@mnorrsken
Copy link

I've created multi-arch builds over at https://hub.docker.com/r/mrnr91/uvicorn-gunicorn-fastapi
(for arm64 arm/v7 amd64)

However I'd rather have them over here of course :) Is there a particular reason that you don't have multi arch builds?

(Note - python-slim wasnt buildable probably because pip had to build packages from source)

@stickperson
Copy link

@mnorrsken do you have the source code? I assume this is a bit more involved than changing FROM python:3.8 to FROM arm64v8/python:3.8

@mnorrsken
Copy link
Author

Not really. Its just that you have to build the dependency images with multi arch too. Tbh I moved on from this and now I just use a standard python image with fastapi and uvicorn in requirements.

@tiangolo
Copy link
Owner

Thank you!

Now that Uvicorn supports managing workers with --workers, including restarting dead ones, there's no need for Gunicorn. That also means that it's much simpler to build a Docker image from scratch now, I updated the docs to explain it.

Because of that, I deprecated this Docker image: https://github.com/tiangolo/uvicorn-gunicorn-docker#-warning-you-probably-dont-need-this-docker-image

And by using an official Python base image you would get multi-arch by default. 😎

Repository owner locked and limited conversation to collaborators Aug 25, 2024
@tiangolo tiangolo converted this issue into discussion #227 Aug 25, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants