feat: extension events add test case #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tisqleditor-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
baurine
reviewed
Jun 28, 2024
| type FocusChangeHelperOptions = { | ||
| onFocusChange: (curSql: SqlStatement[]) => void | ||
| } | ||
| type FocusChangeHelperOptions = (curSql: SqlStatement[]) => void | ||
|
|
||
| const focusChangeHandler = (change: (curSql: SqlStatement[]) => void) => { |
There was a problem hiding this comment.
I feel this extension name onFocusChange doesn't correspond with what it does. According its name, it should be a common extension works with any kind content, not just SQL.
baurine
reviewed
Jun 28, 2024
baurine
reviewed
Jun 28, 2024
baurine
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.