[BACK-2760] Punycode email addresses before sending. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostlevels
force-pushed
the
punycode-email-addresses
branch
from
b66697c to
dc62ca1
Compare
lostlevels
changed the title
toddkazakov
previously approved these changes
Feb 26, 2024
lostlevels
force-pushed
the
punycode-email-addresses
branch
from
dc62ca1 to
ee82f9b
Compare
toddkazakov
previously approved these changes
Oct 15, 2024
clients/sesNotifier.go
Outdated
| @@ -78,7 +83,11 @@ func NewSesNotifier(cfg *SesNotifierConfig, log *zap.SugaredLogger) (*SesNotifie | |||
| func (c *SesNotifier) Send(to []string, subject string, msg string) (int, string) { | |||
| var toAwsAddress = make([]*string, len(to)) | |||
| for i, x := range to { | |||
| toAwsAddress[i] = aws.String(x) | |||
| encodedAddress, err := idna.ToASCII(x) | |||
There was a problem hiding this comment.
You should apply the same changes to mailer, right?
There was a problem hiding this comment.
You should apply the same changes to mailer, right?
It's already applied and merged on mailer becda4799c26
|
/deploy dev1 hydrophone |
|
/deploy dev hydrophone |
|
lostlevels updated values.yaml file in dev1 |
|
lostlevels updated flux policies file in dev1 |
|
lostlevels deployed hydrophone punycode-email-addresses branch to dev1 namespace |
|
/deploy qa1 hydrophone |
|
lostlevels updated values.yaml file in qa1 |
|
lostlevels updated flux policies file in qa1 |
|
lostlevels deployed hydrophone punycode-email-addresses branch to qa1 namespace |
lostlevels
force-pushed
the
punycode-email-addresses
branch
from
3a7f0a2 to
215592d
Compare
toddkazakov
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.