Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): update to 18.3.0 #341

Merged
merged 10 commits into from
May 15, 2024
Merged

chore(android): update to 18.3.0 #341

merged 10 commits into from
May 15, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Feb 21, 2024

@hansemannn
Copy link
Contributor

@m1ga Can you advise if these two PR's are still up to date? I want to add Fido support for play services, but these one should be done first

@m1ga
Copy link
Contributor Author

m1ga commented May 14, 2024

yes, still fine to merge this one and the other one mentioned above to fix the github actions.
I'm using this one for a while now and it works fine. I saw that there is 18.4.0 already (April 16, 2024) but not tested that one yet

@hansemannn
Copy link
Contributor

@m1ga The Android build still fails, it seems like it cannot find the SDK, although ti sdk install 12.2.1.GA works locally.

@m1ga
Copy link
Contributor Author

m1ga commented May 15, 2024

odd..let me check something

@m1ga
Copy link
Contributor Author

m1ga commented May 15, 2024

fixed 😄 It will use Ti 7 now so it need node 18

@m1ga
Copy link
Contributor Author

m1ga commented May 15, 2024

and now a Java error. Think the action is out of data again. Will fix that

@hansemannn hansemannn merged commit 69083d0 into master May 15, 2024
3 checks passed
@hansemannn hansemannn deleted the update_18_3_0 branch May 15, 2024 13:06
@m1ga
Copy link
Contributor Author

m1ga commented May 28, 2024

I've just created a pre-release version so I can link it to the SDK. Then we can push it live together with the next SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants