Moving to cli #272
Merged
Moving to cli #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of using using `cli_abort()` directly
- since we error, it really must - "must" is also what the rlang type checkers use
moved extra line for indicators into the parent method so that it's part of the same cli paragraph
the remaining version (previously overwritten) in `constructor.R` causes the snapshot change
hfrick
commented
Oct 24, 2024
topepo
requested changes
Oct 24, 2024
topepo
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of cli in a lot more places, most notably:
rlang::abort()and the craftygluebort()withcli_abort()Along the way, I've tried to streamline where possible, e.g. the message for the
.default()methods and using the wording "must be" rather than "should be" for consistency with the rlang type-checkers.