clarify step_date() error for wrong features

tidymodels · Oct 25, 2024 · e4ee075 · e4ee075
1 parent 7f3f995
commit e4ee075
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/R/date.R b/R/date.R
@@ -111,8 +111,7 @@ step_date <-
         offenders <- features[!features %in% feat]
 
         cli::cli_abort(c(
-          x = "Possible values of {.arg features} should include:",
-          "*" = "{.or {.val {feat}}}.",
+          x = "Possible values of {.arg features} are {.or {.val {feat}}}.",
           i = "Invalid values were: {.val {offenders}}."
         ))
       }

diff --git a/tests/testthat/_snaps/date.md b/tests/testthat/_snaps/date.md
@@ -15,8 +15,7 @@
         prep()
     Condition
       Error in `step_date()`:
-      x Possible values of `features` should include:
-      * "year", "doy", "mday", "week", "decimal", "semester", "quarter", "dow", or "month".
+      x Possible values of `features` are "year", "doy", "mday", "week", "decimal", "semester", "quarter", "dow", or "month".
       i Invalid values were: "yearly".
 
 ---
@@ -26,8 +25,7 @@
         "daily", "monthly", "yearly")) %>% prep()
     Condition
       Error in `step_date()`:
-      x Possible values of `features` should include:
-      * "year", "doy", "mday", "week", "decimal", "semester", "quarter", "dow", or "month".
+      x Possible values of `features` are "year", "doy", "mday", "week", "decimal", "semester", "quarter", "dow", or "month".
       i Invalid values were: "daily", "monthly", and "yearly".
 
 ---
@@ -37,8 +35,7 @@
         "daily", "month", "yearly")) %>% prep()
     Condition
       Error in `step_date()`:
-      x Possible values of `features` should include:
-      * "year", "doy", "mday", "week", "decimal", "semester", "quarter", "dow", or "month".
+      x Possible values of `features` are "year", "doy", "mday", "week", "decimal", "semester", "quarter", "dow", or "month".
       i Invalid values were: "daily" and "yearly".
 
 # bake method errors when needed non-standard role columns are missing