Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splines2 steps sometimes gives uninformative warnings #1176

Closed
EmilHvitfeldt opened this issue Jul 27, 2023 · 2 comments
Closed

splines2 steps sometimes gives uninformative warnings #1176

EmilHvitfeldt opened this issue Jul 27, 2023 · 2 comments
Assignees
Labels
feature a feature request or enhancement

Comments

@EmilHvitfeldt
Copy link
Member

The warning could be better handled on our end since it doesn't specify which variables are the problem.

library(recipes)

recipe(~., data = mtcars) |>
  step_spline_b(vs, am) |>
  prep()
#> Warning in rcpp_bSpline(x = xx, df = df, degree = degree, internal_knots =
#> knots, : Set equidistant internal knots (found duplicated knots from
#> quantiles).

#> Warning in rcpp_bSpline(x = xx, df = df, degree = degree, internal_knots =
#> knots, : Set equidistant internal knots (found duplicated knots from
#> quantiles).
#> 
#> ── Recipe ──────────────────────────────────────────────────────────────────────
#> 
#> ── Inputs
#> Number of variables by role
#> predictor: 11
#> 
#> ── Training information
#> Training data contained 32 data points and no incomplete rows.
#> 
#> ── Operations
#> • Basis spline expansion: vs, am | Trained

Created on 2023-07-26 with reprex v2.0.2

@EmilHvitfeldt EmilHvitfeldt added the feature a feature request or enhancement label Jul 27, 2023
@EmilHvitfeldt EmilHvitfeldt self-assigned this May 29, 2024
@EmilHvitfeldt
Copy link
Member Author

expect it is kinda messy to deal with warnings...

Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant