Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declense verb in abort by 'offenders' quantity #1400

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

corybrunson
Copy link
Contributor

This PR fixes issue #1399, as illustrated below (adapted from this test).

remotes::install_github("corybrunson/recipes", ref = "declense", quiet = TRUE)
library(recipes)
#> Loading required package: dplyr
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union
#> 
#> Attaching package: 'recipes'
#> The following object is masked from 'package:stats':
#> 
#>     step
recipe(mpg ~ ., data = mtcars) %>% 
  step_pca(vs, am, gear, number = 2) %>% 
  prep()
#> Error in `step_pca()`:
#> Caused by error in `prep()`:
#> ! The following argument was specified but does not exist: `number`.
recipe(mpg ~ ., data = mtcars) %>% 
  step_pca(vs, am, gear, number = 2, category = "blue") %>% 
  prep()
#> Error in `step_pca()`:
#> Caused by error in `prep()`:
#> ! The following arguments were specified but do not exist: `number` and
#>   `category`.

Created on 2024-11-25 with reprex v2.1.1

@corybrunson
Copy link
Contributor Author

Argh, thanks, sorry for omitting the snapshots!

@EmilHvitfeldt
Copy link
Member

no problem!

thank you for your contribution!

@EmilHvitfeldt EmilHvitfeldt merged commit e738967 into tidymodels:main Nov 26, 2024
13 checks passed
@corybrunson corybrunson deleted the declense branch November 26, 2024 01:47
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants