remove check_factor_vars() and make step_dummy() error for character input #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilHvitfeldt
changed the title
topepo
approved these changes
Nov 2, 2023
Merge commit 'fec8b9266e32b54bbb40d2c7d2e597b311d4b71d' #Conflicts: # tests/testthat/_snaps/dummy.md # tests/testthat/_snaps/misc.md
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #1226
According to the documentation,
step_dummy()is able to take character and factor variables.https://github.com/tidymodels/recipes/blob/main/R/dummy.R#L3-L5
This was not the case, as
check_factor_vars()would exclude non-factor variables.This PR fixes that discrepancy by allowingstep_dummy()to take in character predictors. Which was only really an issue whenstrings_as_factors = FALSEThis PR fixes that by letting
step_dummy()error on character input. Which only happens whenstrings_as_factors = FALSE