Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add stability to README output #65

Merged
merged 8 commits into from
Oct 18, 2023
Merged

docs: Add stability to README output #65

merged 8 commits into from
Oct 18, 2023

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Oct 16, 2023

Fix #62

However some sort of order might still be needed? I see other lines in the diff, however if I knit again I don't get any difference.

@maelle maelle requested a review from krlmlr October 16, 2023 08:21
README.Rmd Outdated
@@ -15,6 +15,16 @@ knitr::opts_chunk$set(
pkgload::load_all()

set.seed(20230702)

clean_output <- function(x, options) {
gsub("0x[0-9a-f]+", "0xdeadbeef", x)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maelle maelle marked this pull request as draft October 16, 2023 08:24
@maelle maelle marked this pull request as ready for review October 16, 2023 08:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #65 (212f71d) into main (13e5d48) will not change coverage.
The diff coverage is n/a.

❗ Current head 212f71d differs from pull request most recent head 2788c99. Consider uploading reports for the commit 2788c99 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@          Coverage Diff          @@
##            main     #65   +/-   ##
=====================================
  Coverage   7.53%   7.53%           
=====================================
  Files        121     121           
  Lines      19120   19120           
=====================================
  Hits        1440    1440           
  Misses     17680   17680           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maelle
Copy link
Collaborator Author

maelle commented Oct 16, 2023

@krlmlr is this a tibble option we need to set in README.Rmd?

@krlmlr
Copy link
Member

krlmlr commented Oct 16, 2023

I tried rendering with vanilla, same output.

Would it be possible to make the box look like a box again? Happy to merge then.

@maelle
Copy link
Collaborator Author

maelle commented Oct 17, 2023

It's now stable... on my machine 😅 And it looks like a box again! 🧃

@krlmlr krlmlr changed the title Add stability to README output docs: Add stability to README output Oct 18, 2023
@krlmlr krlmlr merged commit 718411f into tidyverse:main Oct 18, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize rendering of README
3 participants