-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add stability to README output #65
Conversation
README.Rmd
Outdated
@@ -15,6 +15,16 @@ knitr::opts_chunk$set( | |||
pkgload::load_all() | |||
|
|||
set.seed(20230702) | |||
|
|||
clean_output <- function(x, options) { | |||
gsub("0x[0-9a-f]+", "0xdeadbeef", x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the same function as in https://github.com/duckdblabs/duckplyr/blob/13e5d48551982d140bff36de646c7dfdf3602532/tests/testthat/test-relational-duckdb.R#L99
I had never heard of 0xdeadbeef before.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #65 +/- ##
=====================================
Coverage 7.53% 7.53%
=====================================
Files 121 121
Lines 19120 19120
=====================================
Hits 1440 1440
Misses 17680 17680 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@krlmlr is this a tibble option we need to set in README.Rmd? |
I tried rendering with vanilla, same output. Would it be possible to make the box look like a box again? Happy to merge then. |
It's now stable... on my machine 😅 And it looks like a box again! 🧃 |
Fix #62
However some sort of order might still be needed? I see other lines in the diff, however if I knit again I don't get any difference.